[PATCH] D111276: [ArgumentPromotion] Support opaque pointers

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp:729-731
+  // If we're in a recursive function, and the argument is a recursive type
+  // where we do load the same type, we could end up infinitely peeling the
+  // function argument. (This might be too pessimistic for opaque pointers.)
----------------
we're slightly powering down this transform under opaque pointers right? since previously we'd treat different pointer types as different and not bail out in the recursive check as often.
it'd be nice to have a test for this change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111276/new/

https://reviews.llvm.org/D111276