[PATCH] D111835: [bazel] Move MC header usage from Support to tblgen

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 14 13:37:27 PDT 2021


rnk created this revision.
rnk added reviewers: MaskRay, GMNGeoffrey.
rnk requested review of this revision.
Herald added a project: LLVM.

After the TargetRegistry.h move, nothing in Support includes headers
from MC. However, files in tablegen use MC headers, so we must add an
entry for them in tblgen srcs.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111835

Files:
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -187,7 +187,6 @@
     hdrs = glob([
         "include/llvm/Support/**/*.h",
         "include/llvm/ADT/*.h",
-        "include/llvm/MC/*.h",  # TODO(maskray): Fix the layering issue.
     ]) + [
         "include/llvm-c/Core.h",
         "include/llvm-c/DataTypes.h",
@@ -453,6 +452,10 @@
         "utils/TableGen/*.cpp",
         "utils/TableGen/GlobalISel/*.cpp",
 
+        # Some tablegen sources include headers from MC, so these have to be
+        # listed here.
+        "include/llvm/MC/*.h",
+
         # We have to include these headers here as well as in the `hdrs` below
         # to allow the `.cpp` files to use file-relative-inclusion to find
         # them, even though consumers of this library use inclusion relative to


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111835.379824.patch
Type: text/x-patch
Size: 977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211014/a691338c/attachment.bin>


More information about the llvm-commits mailing list