[PATCH] D111770: [DebugInfo] When the enum type causes ODR violation, skip ODRUniquing

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

I think this has come up before in llvm-dev threads, etc - could you link to those in the patch description for further context?

For other folks, bit of a design question: Perhaps we shouldn't special case enums here, and just say that if the ODR uniquing triggers on nodes with different tags, we don't deduplicate in that case? Clearly this is best-effort, I don't think we should go and do full structural equivalence but checking the tag seems cheap and if someone's violated the ODR by accident maybe this'd make it easier on them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111770/new/

https://reviews.llvm.org/D111770