[PATCH] D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool
Noah Shutty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 14 11:18:55 PDT 2021
noajshu marked 10 inline comments as done.
noajshu added inline comments.
================
Comment at: llvm/lib/Support/HTTPClient.cpp:24
+ size_t realsize = size * nmemb;
+ struct MemoryStruct *mem = (struct MemoryStruct *)userp;
+
----------------
phosek wrote:
> phosek wrote:
> > This code should be using C++ casts, not C casts.
> This is still not addressed.
Thanks, I have refactored to use std::vector and eliminated casts entirely.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111252/new/
https://reviews.llvm.org/D111252
More information about the llvm-commits
mailing list