[PATCH] D111643: [ValueTracking] Let propgatesPoison consider single poison operand.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 14 10:36:58 PDT 2021
fhahn marked 5 inline comments as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/PoisonChecking.cpp:303
for (Value *V : I.operands())
Checks.push_back(getPoisonFor(ValToPoison, V));
----------------
nikic wrote:
> This doesn't look quite right to me, shouldn't this only push a check specifically for poison-propagating operands, rather than for all operands if at least one propagates?
Agreed, this is more obvious now, but it should retain the original behavior, right? I'd prefer to not pull in a separate functional improvement in this patch if possible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111643/new/
https://reviews.llvm.org/D111643
More information about the llvm-commits
mailing list