[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.
Zakk Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 14 09:22:31 PDT 2021
khchen added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2089
else
return Error(ValueExprLoc, "bad arch string " + Arch);
}
----------------
maybe we could have a NFC patch later to add
```
// Emit the arch string if needed.
if (!IsIntegerValue)
getTargetStreamer().emitTextAttribute(Tag, ISAInfo->toString());
```
here to reuse `ISAInfo`, and remove 2098~2117 code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105168/new/
https://reviews.llvm.org/D105168
More information about the llvm-commits
mailing list