[PATCH] D111551: [AArch64] Split out processor/tuning features

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Yeah scheduling changes can be a bit difficult to check well. Thanks for adding the new test. There are others like FeatureAggressiveFMA and FeatureLSLFast that can more directly alter codegen, if they are easier to test with.

If not, whilst looking around I found an issue with FeatureAltFPCmp, but otherwise this looks good to me.  (And perhaps consider formatting the ProcessorModel lines to be sorter, but them being like this doesn't block the patch).



================
Comment at: llvm/lib/Target/AArch64/AArch64.td:758
                                     FeatureAlternateSExtLoadCVTF32Pattern,
                                     FeatureAltFPCmp,
                                     FeatureArithmeticBccFusion,
----------------
I was wrong about FeatureAltFPCmp if I said it should be a tuning feature. Looks like it is a 8.5 architecture feature controlling the axflag and xaflag instructions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111551/new/

https://reviews.llvm.org/D111551