[PATCH] D72207: [LLVM-C][bindings/go] Get metadata from a value

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.
Herald added a subscriber: dexonsmith.


================
Comment at: llvm/include/llvm-c/Core.h:3071
  */
 void LLVMSetMetadata(LLVMValueRef Val, unsigned KindID, LLVMValueRef Node);
 
----------------
Shouldn't there be a setter too?

Maybe add a release note saying that `LLVMGetMetadata` is deprecated?

If this is now the advised way to do this, then porting the echo test to use that API instead of the previous one would definitively help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72207/new/

https://reviews.llvm.org/D72207