[PATCH] D111330: [InstCombine] Support arbitrary const shift amount for `lshr (sext i1 ...)`

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/pr52078.ll:2-3
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt -instcombine -S < %s | FileCheck %s --check-prefix=IC
 ; RUN: opt -aggressive-instcombine -instcombine -S < %s | FileCheck %s --check-prefix=AIC_AND_IC
 
----------------
spatel wrote:
> 1. Better to create a common prefix if output is always expected to be the same (just the default "CHECK" would do?).
> 2. Add a -O2 and/or -O3 run, so we know this behaves as expected with the normal pass pipelines (we still want to adjust AIC in those pipelines in another patch?).
1. There's still a small difference in variable names (`%lshr` and `%trunc`) after different folding ways.
2. Ok, added -O2, but have to add one more test to show difference here. (And yes, we're still going to adjust pipeline for AIC later).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111330/new/

https://reviews.llvm.org/D111330