[PATCH] D111643: [ValueTracking] Let propgatesPoison consider single poison operand.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 14 04:06:42 PDT 2021


nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:609
+  bool propagatesPoison(const Operator *I,
+                        const Value *ValAssumedPoison = nullptr);
 
----------------
fhahn wrote:
> nikic wrote:
> > Can we make this function accept (only) a `Use`?
> I think that should be possible, it just requires updating a few of the users.
This isn't really what I had in mind. Why do we need both an Operator and a Use? Can't we make this API accept only a (required) Use and dispatch based on `U.getUser()`? Are there any usages that don't work on a specific Use?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111643/new/

https://reviews.llvm.org/D111643



More information about the llvm-commits mailing list