[PATCH] D110332: [DebugInfo] Limit the size of DIExpressions that we will salvage up to

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM, with naming suggestion inline



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1777
     DII->replaceVariableLocationOp(&I, Op0);
-    if (AdditionalValues.empty()) {
+    bool IsValidSalvageExpr = SalvagedExpr->getNumElements() <= MaxExpressionSize;
+    if (AdditionalValues.empty() && IsValidSalvageExpr) {
----------------
IMO, "Valid" is the wrong term to use here as it suggests a correctness problem. Could I suggest "IsDesirableSalvageExpr"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110332/new/

https://reviews.llvm.org/D110332