[PATCH] D111551: [AArch64] Split out processor/tuning features

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Hi @david-arm, I'm not sure if you rebased this correctly, because I can't see a definition for FeatureUseScalarIncVL in AArch64.td this patch. That's one of the features which should become a tuning feature as well.



================
Comment at: llvm/lib/Target/AArch64/AArch64.td:879
+def ProcessorFeatures {
+  list<SubtargetFeature> A53 = [FeatureCRC, FeatureCrypto, FeatureFPARMv8, FeatureNEON, FeaturePerfMon];
+  list<SubtargetFeature> A55 = [HasV8_2aOps, FeatureCrypto, FeatureFPARMv8, FeatureNEON, FeatureFullFP16, FeatureDotProd, FeatureRCPC, FeaturePerfMon];
----------------
nit: Could you please format these ProcessorFeatures to something a bit easier on the eyes? :)


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:945
+def : ProcessorModel<"kryo", KryoModel, ProcessorFeatures.A53, [TuneKryo]>;
 // Cavium ThunderX/ThunderX T8X  Processors
+def : ProcessorModel<"thunderx", ThunderXT8XModel,  ProcessorFeatures.ThunderX, [TuneThunderX]>;
----------------
nit: missing whitespace above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111551/new/

https://reviews.llvm.org/D111551