[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

In D109825#3060796 <https://reviews.llvm.org/D109825#3060796>, @mubashar_ wrote:

> Added crypto and non-crypto related tests for mcpu in aarch64-cpus.c

Thanks, but did this change miss being updated in the review?



================
Comment at: clang/docs/ReleaseNotes.rst:86
 
+- Support has been added for the following processors (command-line identifiers in parentheses):
+  - Arm Cortex-A510 (cortex-a510)
----------------
dmgreen wrote:
> Can you add an Arm section below and move this to it.
This still needs doing. Also please add a line to the arm section saying "Added support for the Armv9-A, Armv9.1-A and Armv9.2-A architectures."

It looks like there are some llvm release notes in llvm/docs/ReleaseNotes.rst too, that could have a line added.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:149
+                 (AArch64::AEK_BF16 | AArch64::AEK_I8MM | AArch64::AEK_SVE2BITPERM |
+                  AArch64::AEK_PAUTH | AArch64::AEK_PAUTH | AArch64::AEK_MTE |
+                  AArch64::AEK_SSBS | AArch64::AEK_SB | AArch64::AEK_FP16FML))
----------------
AEK_PAUTH is twice here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109825/new/

https://reviews.llvm.org/D109825