[PATCH] D111731: [llvm-readelf] Make -W an alias of --wide

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 23:56:28 PDT 2021


jhenderson added a comment.

In D111731#3061846 <https://reviews.llvm.org/D111731#3061846>, @MaskRay wrote:

> Does this change --help output? If not, seems unnecessary?

We've got some downstream code that intends to iterate over all possibly specified options, regardless of their eventual impact on the behaviour of the tool. Without this change, the "W" and "wide" options would appear as separate entries, unlike other aliases, which is not desirable.

Plus, as @gbreynoo pointed out, this ensures consistency - in llvm-objdump the same options are aliases, rather than separate options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111731/new/

https://reviews.llvm.org/D111731



More information about the llvm-commits mailing list