[PATCH] D111688: [MachineSink] Compile time improvement for large testcases which has many kill flags We did a experiment and observed dramatic decrease on compilation time which spent on clearing kill flags.
Bing Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 13 19:31:40 PDT 2021
yubing updated this revision to Diff 379585.
yubing added a comment.
Replace DenseSet<unsigned> with DenseSet<Register>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111688/new/
https://reviews.llvm.org/D111688
Files:
llvm/lib/CodeGen/MachineSink.cpp
Index: llvm/lib/CodeGen/MachineSink.cpp
===================================================================
--- llvm/lib/CodeGen/MachineSink.cpp
+++ llvm/lib/CodeGen/MachineSink.cpp
@@ -131,7 +131,7 @@
// will be split.
SetVector<std::pair<MachineBasicBlock *, MachineBasicBlock *>> ToSplit;
- SparseBitVector<> RegsToClearKillFlags;
+ DenseSet<Register> RegsToClearKillFlags;
using AllSuccsCache =
std::map<MachineBasicBlock *, SmallVector<MachineBasicBlock *, 4>>;
@@ -1439,7 +1439,7 @@
// used registers.
for (MachineOperand &MO : MI.operands()) {
if (MO.isReg() && MO.isUse())
- RegsToClearKillFlags.set(MO.getReg()); // Remember to clear kill flags.
+ RegsToClearKillFlags.insert(MO.getReg()); // Remember to clear kill flags.
}
return true;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111688.379585.patch
Type: text/x-patch
Size: 810 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211014/783164a8/attachment.bin>
More information about the llvm-commits
mailing list