[PATCH] D111699: [XCOFF] [llvm-readobj] replace tests using binary as input with tests generated by yaml2obj.
ChenZheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 13 19:19:39 PDT 2021
shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.
LGTM with one small nit.
================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/relocations.test:62
+Symbols:
+ - Name: .text
+ Value: 0x0
----------------
nit: This is not a good symbol name that the relocation entries will point to. Maybe we need another name. Like `foo` `bar` and so on.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111699/new/
https://reviews.llvm.org/D111699
More information about the llvm-commits
mailing list