[PATCH] D111769: [Polly][NFC] Switch checkIslAstExprInt to use RAII instead of manually freeing Expr

Max Fan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 18:50:26 PDT 2021


InnovativeInventor marked 3 inline comments as done.
InnovativeInventor added inline comments.


================
Comment at: polly/lib/CodeGen/IslNodeBuilder.cpp:187
   isl::ast_expr UB = getUpperBound(For, Predicate);
   if (isl_ast_expr_get_type(UB.get()) != isl_ast_expr_int)
     return -1;
----------------
It looks like I should change this to be `!Expr.isa<isl::ast_expr_int>()` as well, right? If so, should I make a different review or do you want each patch to be tightly scoped and not contain a hodgepodge of changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111769/new/

https://reviews.llvm.org/D111769



More information about the llvm-commits mailing list