[PATCH] D111749: [llvm-profgen] Also ignore the first external branch

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/inline-noprobe2.test:1
-
+; REQUIRES: asserts
+; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/artificial-branch.perfscript --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t  --skip-symbolization --use-offset=0 --debug-only=perf-reader 2>&1 | FileCheck %s --check-prefix=CHECK-LBR
----------------
wenlei wrote:
> can we avoid having test depending on debug prints as much as we can? can check the final result only in this case.
I see, the final result is enough for this case.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:495
         continue;
       else if (!LBRStack.empty()) {
         WithColor::warning()
----------------
wenlei wrote:
> nit: with the break at the end, it's probably more readable if we separate the `continue` by replacing the `else if` with `if`.
Good point!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111749/new/

https://reviews.llvm.org/D111749