[PATCH] D111753: [llvm-mca][timeline] Indicate output was stopped due to cycle limit.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 12:13:30 PDT 2021


dsanders created this revision.
dsanders added reviewers: andreadb, qcolombet.
Herald added a subscriber: gbedwell.
dsanders requested review of this revision.
Herald added a project: LLVM.

It can be a bit confusing to stop with no explanation so we should indicate
when further output was prevented by the cycle limit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111753

Files:
  llvm/tools/llvm-mca/Views/TimelineView.cpp


Index: llvm/tools/llvm-mca/Views/TimelineView.cpp
===================================================================
--- llvm/tools/llvm-mca/Views/TimelineView.cpp
+++ llvm/tools/llvm-mca/Views/TimelineView.cpp
@@ -296,8 +296,10 @@
       // attribute is set correctly whether or not it is greater
       // than timeline-max-cycles so we can use that to ensure
       // we don't early exit because of a 0 latency instruction.
-      if (Entry.CycleRetired == 0 && Entry.CycleExecuted != 0)
+      if (Entry.CycleRetired == 0 && Entry.CycleExecuted != 0) {
+        FOS << "Truncated display due to cycle limit\n";
         return;
+      }
 
       unsigned SourceIndex = IID % Source.size();
       printTimelineViewEntry(FOS, Entry, Iteration, SourceIndex);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111753.379490.patch
Type: text/x-patch
Size: 763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211013/6e53001b/attachment.bin>


More information about the llvm-commits mailing list