[PATCH] D111416: [Demangle] Add support for D simple basic and compound types

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:449
+  switch (*Mangled) {
+  case 'O': /* shared(T) */
+    Mangled++;
----------------
Prefer `//` for C++ (https://llvm.org/docs/CodingStandards.html#comment-formatting)




================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:450
+  case 'O': /* shared(T) */
+    Mangled++;
+    Decl->append("shared(");
----------------
Prefer pre-increment `++Mangled` (https://llvm.org/docs/CodingStandards.html#prefer-preincrement)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111416/new/

https://reviews.llvm.org/D111416