[PATCH] D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 10:36:39 PDT 2021


rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.

Conceptually, it seems fine. As is, this will break the MSVC build, right? It doesn't support `__attribute__`. You need to add a portability macro in Compiler.h, or use ifdefs inline.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111682/new/

https://reviews.llvm.org/D111682



More information about the llvm-commits mailing list