[PATCH] D107872: [SimplifyLibCalls] propagate tail/musttail/notail flags on CallInsts
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 13 10:19:41 PDT 2021
nickdesaulniers added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2435-2444
if (Value *With = Simplifier.optimizeCall(CI, Builder)) {
+ if (CI->isMustTailCall()) {
+ auto *NewCI = dyn_cast<CallInst>(With);
+ assert(NewCI && "replaced musttail call with non-CallInst");
+ assert(NewCI->isMustTailCall() &&
+ "replaced musttail call with non-musttail call");
+ (void)NewCI;
----------------
Thinking about this overnight...if this is the one place where replacement occurs, then why don't I just copy over the tail call kind here, rather than use the adapter in multiple locations in LibCallSimplifier? As I've already demonstrating, this approach is error prone; perhaps I could "do the work" here. Then we wouldn't need the asserts here, and this becomes a smaller change. Let me give that a shot and see if there's something I'm missing here as to why that can't be done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107872/new/
https://reviews.llvm.org/D107872
More information about the llvm-commits
mailing list