[llvm] b44eac1 - [AMDGPU] Remove unneeded emit literal check

Joe Nash via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 10:04:09 PDT 2021


Author: Joe Nash
Date: 2021-10-13T12:46:22-04:00
New Revision: b44eac1b851a63861e61fa47f43de27773c3ce70

URL: https://github.com/llvm/llvm-project/commit/b44eac1b851a63861e61fa47f43de27773c3ce70
DIFF: https://github.com/llvm/llvm-project/commit/b44eac1b851a63861e61fa47f43de27773c3ce70.diff

LOG: [AMDGPU] Remove unneeded emit literal check

NFC. This check does not verify any functional property since size 8
was added. Remove it for simplicity.

Reviewed By: rampitec

Differential Revision: https://reviews.llvm.org/D111737

Change-Id: Ifd7cbd324a137f939d8dc04acb8fbd54c9527a42

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp b/llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
index 41196054c4825..77f219aaa3abf 100644
--- a/llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
+++ b/llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
@@ -547,8 +547,7 @@ uint64_t SIMCCodeEmitter::getMachineOpValue(const MCInst &MI,
   const MCInstrDesc &Desc = MCII.get(MI.getOpcode());
   if (AMDGPU::isSISrcOperand(Desc, OpNo)) {
     uint32_t Enc = getLitEncoding(MO, Desc.OpInfo[OpNo], STI);
-    if (Enc != ~0U &&
-        (Enc != 255 || Desc.getSize() == 4 || Desc.getSize() == 8))
+    if (Enc != ~0U)
       return Enc;
 
   } else if (MO.isImm())


        


More information about the llvm-commits mailing list