[PATCH] D111508: [RISCV] Optimize immediate materialisation with BSETI/BCLRI

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.cpp:213
+
+    // Try to use BCLRI for upper 32-bit if the original lower 32-bit is
+    // negative int32, or use BSETI for upper 32-bit if the original lower
----------------
"32-bit" -> "32 bits"

"32-bit is" -> "32 bits are"

32-bit with a hyphen refers to a 32-bit architecture. Your just talking about number of bits here so no hyphen.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.cpp:214
+    // Try to use BCLRI for upper 32-bit if the original lower 32-bit is
+    // negative int32, or use BSETI for upper 32-bit if the original lower
+    // 32-bit is positive int32.
----------------
32-bit -> 32 bits


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.cpp:215
+    // negative int32, or use BSETI for upper 32-bit if the original lower
+    // 32-bit is positive int32.
+    int32_t Lo = Val;
----------------
32-bit is -> 32 bits are


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111508/new/

https://reviews.llvm.org/D111508