[PATCH] D111595: [X86] Move splat addends from the gather/scatter index operand to the base address

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:2503
+    X86ISelAddressMode Backup = AM;
+    if (!matchVectorAddressRecursively(N.getOperand(0), AM,
+                                       Depth+1) &&
----------------
Please run clang-format


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:2526
+/// Helper for selectVectorAddr. Handles things that can be folded into a
+/// gather scatter address. The index register and scale should have already
+/// been handled.
----------------
"gather scatter" -> "gather/scatter"    or "gather or scatter"


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:50268
+
+      // It's also possible, base is just a constant. In that case case just
+      // replace it with 0 and move the displacement into the index.
----------------
Drop the comma after possible.

"case case" -> "case,"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111595/new/

https://reviews.llvm.org/D111595