[PATCH] D111681: [IVUsers] Move preheader check into SCEVExpander

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 09:07:40 PDT 2021


reames added a comment.

LGTM.

Have to admit, this is slightly more delicate than I'd realized.  Not sure I'd have pushed for this if I realized at the time it had to be an expansion safety predicate as opposed to simply handled (with possibly sub-optimal codegen) during expansion.  The benefit seems smaller.  Happy to have this land, but would also be fine abandoning this.  I'll leave it to your judgement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111681/new/

https://reviews.llvm.org/D111681



More information about the llvm-commits mailing list