[PATCH] D111652: [AMDGPU] Add more tests for build_vector

Wed Oct 13 08:22:29 PDT 2021

foad added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/build_vector.ll:4
+; RUN: llc < %s -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs | FileCheck %s --check-prefixes=SI,GFX8,ALL
+; RUN: llc < %s -mtriple=amdgcn-amd-amdpal -mcpu=gfx1030 -verify-machineinstrs | FileCheck %s --check-prefixes=GFX10,SI-DAG,ALL

----------------
jpages wrote:
> foad wrote:
> > Similarly this should be SI, not SI-DAG :)
> Unfortunately, the code is too different between the different architectures with GFX10....
> 
> I think I will update it with the script.
No, I mean that on the FileCheck command line you just specify "--check-prefixes=...,SI,...". It's fine to use "SI-DAG:" checks in the file.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111652/new/

https://reviews.llvm.org/D111652