[PATCH] D111538: [X86] Prefer VEX encoding in X86 assembler.
    Roman Lebedev via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Oct 13 07:19:09 PDT 2021
    
    
  
lebedev.ri added a comment.
In D111538#3061264 <https://reviews.llvm.org/D111538#3061264>, @LuoYuanke wrote:
> In D111538#3061027 <https://reviews.llvm.org/D111538#3061027>, @lebedev.ri wrote:
>
>> Having something specific to some specific target in a generic code
>> (esp. if there is no precedent for it) seems conceptually wrong.
>
> We can see in line 636, it also do some specific things for ARM. We can also see ReportMultipleNearMisses is added for ARM.
I think you understand that i'm not talking about doing specific for target X - adding new hooks is fine,
but specifically about checking for the subclass name and doing different stuff based on that.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111538/new/
https://reviews.llvm.org/D111538
    
    
More information about the llvm-commits
mailing list