[PATCH] D111706: [lld-macho] Use StringRef's hash code as keys of loadedArchives

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 06:53:44 PDT 2021


oontvoo added a comment.

> .... and if the StringRef instance's actual string data is released, such lookup will return false even though the value is still present in the map ....

Hmmm, do we have a use-after-free bug somewhere? 
IUC, all the StringRef should have their data "saved" in the saver and none of it should get freed while we're still linking

Could you add a test to reproduce this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111706/new/

https://reviews.llvm.org/D111706



More information about the llvm-commits mailing list