[PATCH] D111437: [SystemZ/z/OS] Implement GOFF writer for empty files

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: llvm/lib/MC/GOFFObjectWriter.cpp:274
+  OS.write_zeros(3);                           // Reserved
+  OS.write_be<uint32_t>(OS.logical_records()); // Record Count
+  OS.write_be<uint32_t>(ESDID);                // ESDID (of entry point)
----------------
Kai wrote:
> kpn wrote:
> > I have found it useful to use the Unix 'dd' command to slide up GOFF files when they cause the Binder to abend. This becomes much harder when this record count field is used. I'm not sure what the upside of this field is.
> I need to check if the binder is happy without this field.
> Both xlc and xlcang set the record count, so setting the field is consistent with these compilers.
We've been putting zero for the record count for nearly 20 years. It's been fine all that time. If it stopped working I'd get a phone call pretty quickly. Last night's builds on V2R4 ran fine, for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111437/new/

https://reviews.llvm.org/D111437