[PATCH] D111660: [FuncSpec] Make sure function is actually the callee before trying to specialize.

[duk via Phabricator via llvm-commits]

duck-37 added a comment.

In D111660#3061173 <https://reviews.llvm.org/D111660#3061173>, @SjoerdMeijer wrote:

> Oh wait, sorry, regressions test fail, they trigger this assert. We should assert that CS.getCalledFunction() == F? Also, in asserts it is custom to add a message/diagnostic, so that will be:
>
>   assert(CS.getCalledFunction() == F && "function and callee should be same");
>
> or something along those lines.



In D111660#3061173 <https://reviews.llvm.org/D111660#3061173>, @SjoerdMeijer wrote:

> Oh wait, sorry, regressions test fail, they trigger this assert. We should assert that CS.getCalledFunction() == F? Also, in asserts it is custom to add a message/diagnostic, so that will be:
>
>   assert(CS.getCalledFunction() == F && "function and callee should be same");
>
> or something along those lines.

You're absolutely right, I'm running on not that much sleep at the moment, sorry!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111660/new/

https://reviews.llvm.org/D111660