[PATCH] D111403: [Inliner] Don't inline functions with incompatible vscale_range attributes

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes added inline comments.


================
Comment at: llvm/test/Transforms/Inline/inline-vscale-range.ll:4
+
+; CHECK: remark: {{.*}} 'callee_restricted_min' is not inlined into 'caller_unbounded_min__callee_restricted_min': incompatible vscale_range attributes
+; CHECK: remark: {{.*}} 'callee_restricted_min' is not inlined into 'caller_unrestricted_min__callee_restricted_min': incompatible vscale_range attributes
----------------
c-rhodes wrote:
> sdesmalen wrote:
> > It may be easier to read the tests if you move the `CHECK: remark:`'s to the caller definitions.
> > Can you also enable `-pass-remarks=inline` and have CHECK lines to check that a function has been inlined (for the positive cases) ?
> > It may be easier to read the tests if you move the `CHECK: remark:`'s to the caller definitions.
> 
> All the remarks are emitted at the top, I don't think this will work with the CHECK-LABELs but I'll try.
> 
> > Can you also enable `-pass-remarks=inline` and have CHECK lines to check that a function has been inlined (for the positive cases) ?
> 
> Sure 
I've added positive tests. I agree it would be nice to have the remark CHECKs beside the relevant functions but it doesn't like that. I looked at some loop vectorizer test (`scalable-vf-hint.ll`) I recalled from a while back and there we have 2 run lines so the remarks are inline, bit I'm not sure if that's worth doing here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111403/new/

https://reviews.llvm.org/D111403