[llvm] e845ca2 - Follow up a3936a6c19c to work around an old compiler bug

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 05:29:42 PDT 2021


Author: Jeremy Morse
Date: 2021-10-13T13:27:25+01:00
New Revision: e845ca2ff121b31bef49c1271d2a0926d7fe5989

URL: https://github.com/llvm/llvm-project/commit/e845ca2ff121b31bef49c1271d2a0926d7fe5989
DIFF: https://github.com/llvm/llvm-project/commit/e845ca2ff121b31bef49c1271d2a0926d7fe5989.diff

LOG: Follow up a3936a6c19c to work around an old compiler bug

Old versions of gcc want template specialisations to happen within the
namespace where the template lives; this is still present in gcc 5.1, which
we officially support, so it has to be worked around.

Added: 
    

Modified: 
    llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
index 904b7fd9ba87..80aef47aa934 100644
--- a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
+++ b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
@@ -1972,11 +1972,13 @@ using MachineDomTreeBase = DomTreeBase<MachineBasicBlock>::NodeType;
 using MachineDomTreeChildGetter =
     typename IDFCalculatorDetail::ChildrenGetterTy<MachineDomTreeBase, false>;
 
+namespace IDFCalculatorDetail {
 template <>
 typename MachineDomTreeChildGetter::ChildrenTy
 MachineDomTreeChildGetter::get(const NodeRef &N) {
   return {N->succ_begin(), N->succ_end()};
 }
+} // namespace IDFCalculatorDetail
 } // namespace llvm
 
 void InstrRefBasedLDV::BlockPHIPlacement(


        


More information about the llvm-commits mailing list