[PATCH] D111403: [Inliner] Don't inline functions with incompatible vscale_range attributes

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Thanks, that looks a lot simpler now!



================
Comment at: llvm/test/Transforms/Inline/inline-vscale-range.ll:4
+
+; CHECK: remark: {{.*}} 'callee_restricted_min' is not inlined into 'caller_unbounded_min__callee_restricted_min': incompatible vscale_range attributes
+; CHECK: remark: {{.*}} 'callee_restricted_min' is not inlined into 'caller_unrestricted_min__callee_restricted_min': incompatible vscale_range attributes
----------------
It may be easier to read the tests if you move the `CHECK: remark:`'s to the caller definitions.
Can you also enable `-pass-remarks=inline` and have CHECK lines to check that a function has been inlined (for the positive cases) ?


================
Comment at: llvm/test/Transforms/Inline/inline-vscale-range.ll:20
+define internal void @callee_restricted_min() vscale_range(2, 4) {
+; CHECK-LABEL: @callee_restricted_min(
+; CHECK-NEXT:    ret void
----------------
why are these CHECK lines here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111403/new/

https://reviews.llvm.org/D111403