[PATCH] D111551: [AArch64] Split out processor/tuning features

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 13 04:50:48 PDT 2021


sdesmalen added a comment.

@david-arm You should probably rebase your patch, because I noticed `UseScalarIncVL` is still marked as an architecture feature (but I can't see it in this revision yet).

To help the review of this patch, I wrote a tablegen backend to flatten all the subtarget-features for each processor and mark them as either (arch) feature or tuning feature. Then I created a diff between the before/after of this patch. The result is here:  F19590126 <https://reviews.llvm.org/F19590126>.

Would there be any use in having an llvm tool that dumps the processor features? (I was thinking of having a tool, say `dump-cpu-features`, which could be used in tests, e.g.

  ; RUN: dump-cpu-features --target=aarch64
  ; CHECK:       Processor: ....
  ; CHECK-NEXT: HasNEON = true [feature]
  ; CHECK-NEXT: HasSHA2 = true [feature]
  ; ...

If so, I could spend some more time to make this into a little tool and generate some tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111551/new/

https://reviews.llvm.org/D111551



More information about the llvm-commits mailing list