[PATCH] D111611: [NFC] [LoopPeel] Change the way DT is updated for loop exits
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 13 03:42:57 PDT 2021
mkazantsev added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:567
+ ValueToValueMapTy &VMap, ValueToValueMapTy &LVMap, DomTreeUpdater &DTU,
+ SmallDenseMap<BasicBlock *, BasicBlock *> &LoopBlocksIDoms,
LoopInfo *LI, ArrayRef<MDNode *> LoopLocalNoAliasDeclScopes) {
----------------
dmakogon wrote:
> mkazantsev wrote:
> > Pls make it const
> How are we going to apply updates to it then? `DTU::applyUpdates` is a non-const function
LoopBlocksIDoms should be const, not DTU.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111611/new/
https://reviews.llvm.org/D111611
More information about the llvm-commits
mailing list