[PATCH] D111661: [FuncSpec] Only visit uses of the instruction instead of every constant use.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added reviewers: ChuanqiXu, snehasish.
SjoerdMeijer added a comment.

Thanks, that sounds like a really good improvement!

I just wanted to quickly check your testing strategy. Problem is function specialisation isn't enabled by default, so isn't covered by the upstream buildbots and tests. I shot myself in the foot recently by introducing a performance regression that I noticed later and then took me more time to fix (I am tracking performance now with function specialisation enabled). 
I usually hack the compiler in `Transforms/IPO/PassManagerBuilder.cpp:175` as I find that easier to pass flags in different build systems and change `cl::init(false)` into `true`, and then run some code: a stage2 build would be good, and the llvm test suite too, these would be the minimum and function specialisation should trigger in both. And sorry if you're doing this already, but just wanted to check. If you can it would be good if you run SPEC too and see that the MCF score is unaffected (with LTO that is, it should trigger on MCF so if it doesn't anymore we have a problem :) ).  
But I think I can quickly run SPEC today, so will do that and report back here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111661/new/

https://reviews.llvm.org/D111661