[PATCH] D111652: [AMDGPU] Add more tests for build_vector

Wed Oct 13 01:21:30 PDT 2021

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks obviously fine once you have fixed the --check-prefixes problem. You could also auto-generate the checks for this file with update_llc_test_checks if you wanted to.

================
Comment at: llvm/test/CodeGen/AMDGPU/build_vector.ll:1-4
+; RUN: llc < %s -march=r600 -mcpu=redwood | FileCheck %s --check-prefixes=R600,ALL-LABEL
+; RUN: llc < %s -march=amdgcn -verify-machineinstrs | FileCheck %s --check-prefixes=SI,GFX6,ALL-LABEL
+; RUN: llc < %s -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs | FileCheck %s --check-prefixes=SI,GFX8,ALL-LABEL
+; RUN: llc < %s -mtriple=amdgcn-amd-amdpal -mcpu=gfx1030 -verify-machineinstrs | FileCheck %s --check-prefixes=GFX10,SI-DAG,ALL-LABEL
----------------
You should just specify "ALL" on the command line, not "ALL-LABEL". FileCheck has a generic feature where you can put suffixes like "-LABEL" or "-DAG" on any prefix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111652/new/

https://reviews.llvm.org/D111652