[PATCH] D111159: [UnknownProvenance] Introduce UnknownProvenance constant

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

Thanks for the feedback !



================
Comment at: llvm/include/llvm-c/Core.h:1917
+ */
+LLVMValueRef LLVMGetUnknownProvenance(LLVMTypeRef Ty);
+
----------------
deadalnix wrote:
> Where is the implementation for these?
Ah.. The implementation is in D111162, but I had to move the header earlier for the enum. Probably better to just add the implementation in this revision..


================
Comment at: llvm/include/llvm/IR/Constants.h:579
+  /// which reduces the amount of casting needed in parts of the compiler.
+  inline PointerType *getType() const {
+    return cast<PointerType>(Value::getType());
----------------
deadalnix wrote:
> Isn't inline implied by the fact this is defined directly within the class?
Yes it is. That's what I get for copy-pasting from `ConstantPointerNull`..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111159/new/

https://reviews.llvm.org/D111159