[PATCH] D111688: [MachineSink] Compile time improvement for large testcases which has many kill flags We did a experiment and observed dramatic decrease on compilation time which spent on clearing kill flags.

[Bing Yu via Phabricator via llvm-commits]

yubing added a comment.

In D111688#3060458 <https://reviews.llvm.org/D111688#3060458>, @pengfei wrote:

> In D111688#3060447 <https://reviews.llvm.org/D111688#3060447>, @yubing wrote:
>
>> In D111688#3060446 <https://reviews.llvm.org/D111688#3060446>, @pengfei wrote:
>>
>>> How do you calculate the kill flags handling time?
>>
>> I am using std::chrono::high_resolution_clock::now()
>>
>>   std::chrono::high_resolution_clock::time_point start = std::chrono::high_resolution_clock::now();
>>   RegsToClearKillFlags.insert(MO.getReg()); // Remember to clear kill flags.
>>   std::chrono::duration<double, std::milli> duration = std::chrono::high_resolution_clock::now() - start;
>
> Do you also calculate the time of all the access to RegsToClearKillFlags?

The rest code of maintaining RegsToClearKillFlags contributes minority of the compilation time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111688/new/

https://reviews.llvm.org/D111688