[PATCH] D111611: [NFC] [LoopPeel] Change the way DT is updated for loop exits

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 21:45:23 PDT 2021


mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:578
 
+  SmallVector<DominatorTree::UpdateType, 8> DTUpdates;
+
----------------
mkazantsev wrote:
> You already have DTU. You can just call `insertEdge/deleteEdge` on it without any checks. They will not be applied immediately because you are using lazy update strategy. So no need for `DTUpdates` at all.
**applyUpdates, since these two are deprecated. But a separate vector is not needed anyways, you have this lazy vector in DTU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111611/new/

https://reviews.llvm.org/D111611



More information about the llvm-commits mailing list