[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/unittests/Support/CharSetTest.cpp:130
+
+TEST(CharSet, Identity) {
+  // Hello string.
----------------
The other cases of "identity conversion" look like they would have suspicious behaviour. If they do, then this test is insufficient.


================
Comment at: llvm/unittests/Support/CharSetTest.cpp:191
+
+} // namespace
----------------
There is no representation in the testing of stateful encodings.

Reasonable tests (separately for ISO-2022-JP and IBM-939) include:

  - "Returning to the initial shift state" when in the initial shift state generates an empty output sequence.
  - "Returning to the initial shift state" after the previous conversion ended with a character that requires a shift from the initial shift state generates a non-empty output sequence.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88741/new/

https://reviews.llvm.org/D88741