[PATCH] D111538: [X86] Prefer VEX encoding in X86 assembler.

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 19:44:39 PDT 2021


skan added inline comments.


================
Comment at: llvm/utils/TableGen/AsmMatcherEmitter.cpp:639-640
 
+    if (TheDef->isSubClassOf("X86Inst"))
+      return TheDef->getID() < RHS.TheDef->getID();
+
----------------
Suggestion: This is X86-specific code in target-independent file. Please add some comments about why you specialize the code for X86 here and how the strict total order of ID is defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111538/new/

https://reviews.llvm.org/D111538



More information about the llvm-commits mailing list