[PATCH] D111685: [Polly][NFC] Clean up Polly's getting started docs

Tue Oct 12 18:30:22 PDT 2021

InnovativeInventor marked 2 inline comments as done.
InnovativeInventor added inline comments.

================
Comment at: polly/www/get_started.html:18
 <h1>Building and Installing Polly</h1>
+You can build Polly with <a href="https://ninja-build.org/">Ninja</a> or <a href="https://cmake.org/">cmake</a>.
+Other generators build systems can also be used, but are not supported.
----------------
Meinersbur wrote:
> Ninja and CMake are not alternatives of each other. Your can build LLVM with either CMake and ninja (`cmake -GNinja`), CMake and make (`cmake -G"Unix Makefiles"`), or most other generators supported by CMake, such as XCode, Visual Studio.
Oh, whoops. Just fixed this -- thanks for clarifiying!

================
Comment at: polly/www/get_started.html:30
 <pre>
-git clone https://github.com/llvm/llvm-project.git llvm_git
+git clone --depth 1 https://github.com/llvm/llvm-project.git
 </pre>
----------------
Meinersbur wrote:
> Did you try this? How much disk space does it save?
It saves a non-trivial amount. A full clone takes about 3.2 GB, whereas a shallow clone takes about 1.5 GB (so ~53% reduction).

================
Comment at: polly/www/get_started.html:37
+mkdir build && cd build
+cmake -G Ninja '-DLLVM_ENABLE_PROJECTS=clang;polly' ../llvm
+ninja
----------------
Meinersbur wrote:
> This will create a debug build which may use a lot of memory to build and is slow. For starters, I'd recommend a Release+Assert build unless one starts using a debugger (or wants accurate line numbers in crash traces). I.e. `-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON`.
> 
> What do you think?
Sounds good -- just added it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111685/new/

https://reviews.llvm.org/D111685