[PATCH] D110658: [InlineAdvisor] Add -inline-replay-strict to replay inline decisions only in callers that have remarks

[Di Mo via Phabricator via llvm-commits]

modimo added a comment.

@mtrofin Adding the enum `ReplayInlineScope` revealed that I was adding `#include "llvm/Analysis/ReplayInlineAdvisor.h"` to InlineAdvisor.cpp which seems wrong from a dependency perspective. Looking at how the other advisors interact it seems the interface is to declare a `getReplayInlineAdvisor` in InlineAdvisor.h similar to `getReleaseModeAdvisor` and also define `ReplayInlineScope` there so including InlineAdvisor.h by itself is enough to be able to create a ReplayInlineAdvisor. Does this look right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110658/new/

https://reviews.llvm.org/D110658