[PATCH] D111593: [DebugInfo] retainedTypes should not have subprograms

Ellis Hoag via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 17:47:31 PDT 2021


ellis created this revision.
Herald added a subscriber: hiraditya.
ellis updated this revision to Diff 378846.
ellis added a comment.
ellis added a project: debug-info.
ellis published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix tests


ellis added a comment.

I found this while looking through the callsites to `getOrCreateSubprogramDIE()`. I was thinking of adding an assert to check that `retainedTypes` don't include SPs but it seems there are a lot of tests that do this.


After D80369 <https://reviews.llvm.org/D80369>, the `retainedTypes` in CU's should not have any
subprograms so we should not handle that case when emitting debug info.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111593

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-indirect-param.mir
  llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-orr-moves.mir
  llvm/test/DebugInfo/MIR/X86/callsite-stack-value.mir
  llvm/test/DebugInfo/MIR/X86/debug-call-site-param.mir
  llvm/test/DebugInfo/X86/convert-loclist.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111593.378846.patch
Type: text/x-patch
Size: 8698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211013/add37d91/attachment.bin>


More information about the llvm-commits mailing list