[PATCH] D111345: [WebAssembly] Add import info to `dylink` section of shared libraries

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 17:14:17 PDT 2021


sbc100 added inline comments.


================
Comment at: lld/wasm/SyntheticSections.cpp:91
+      }
+      if (sym->isUndefWeak()) {
+        importInfo.push_back(sym);
----------------
dschuff wrote:
> is it only for weak undef symbols? What about just regular strong undef symbols?
We don't need to export any extra flags for that case.. i.e. strong is the default for imports.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111345/new/

https://reviews.llvm.org/D111345



More information about the llvm-commits mailing list