[PATCH] D111388: [WebAssembly] Make EH work with dynamic linking

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 15:19:00 PDT 2021


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Symbols.h:70
            symbolKind == UndefinedGlobalKind ||
-           symbolKind == UndefinedTableKind;
+           symbolKind == UndefinedTableKind || symbolKind == UndefinedTagKind;
   }
----------------
aheejin wrote:
> sbc100 wrote:
> > Maybe follow the pattern of one comparison per line here?
> This is what clang-format insists. Currently our wasm lld code conforms to clang-format nearly 99%, so I'm not sure if this is worth making an exception..?
Clang-format is the boss I guess. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111388/new/

https://reviews.llvm.org/D111388



More information about the llvm-commits mailing list