[PATCH] D61243: Check build-type dependent variables for -flto as well.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 14:57:59 PDT 2021


MatzeB added a comment.

>> I wonder, why it's {C,CXX,LD}FLAGS, and not CMAKE_*_FLAGS directly.
>
> Not sure, TBH.

As far as I know the idea is that CFLAGS/CXXFLAGS/LDFLAGS are maintained as cmake lists so you can do stuff like `list(FILTER` on them. `CMAKE_xxx_FLAGS` are strings so it's harder to do it there.

The desire to have them as lists stems from the fact that the first version of the test-suite cmake files were mostly created by an automatic script reading the Makefiles needing to translate stuff like `$(filter -lstdc++,$(LDFLAGS))`...

So no strong reason, but will be annoying to change now.


Repository:
  rOLDT svn-test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61243/new/

https://reviews.llvm.org/D61243



More information about the llvm-commits mailing list