[PATCH] D111416: [Demangle] Add support for D simple basic and compound types

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D111416#3056708 <https://reviews.llvm.org/D111416#3056708>, @ljmf00 wrote:

> In D111416#3052693 <https://reviews.llvm.org/D111416#3052693>, @dblaikie wrote:
>
>> Missing test coverage - all the cases added should be tested.
>
> Well, I thought about this but currently, the demangler is not prepending the type to the demangled symbol so, there is no way to visually test this until https://reviews.llvm.org/D111421. That is why those tests get introduced there instead (types are shown in function parameters). I can add tests to check if this, at least, doesn't fail (nullptr) although I thought that adding tests for all of the types expecting the same output was useless when https://reviews.llvm.org/D111421 get introduced.

Perhaps the patches are out of order then, or split too much - code should be tested when it is introduced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111416/new/

https://reviews.llvm.org/D111416